Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zavod shuttle destroyed #19071

Merged
merged 12 commits into from
May 12, 2024
Merged

Zavod shuttle destroyed #19071

merged 12 commits into from
May 12, 2024

Conversation

CactusMouth
Copy link
Contributor

Adds a new Awaysite - The Zavod Shuttle.

StrongDMM-2024-04-30 15 49 00

FEATURING ALL NEW:

  • Drones and turrets!
  • Decent loot other than just Phoron.
  • A cool new place to explore.
  • Uses Danger:Reward ratio so you can't just stumble upon an automatic shotgun without a challenge!

Changelog will be added in a few minutes, thanks.

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 30, 2024
@CactusMouth
Copy link
Contributor Author

!review

DreamySkrell
DreamySkrell reviewed May 2, 2024
View reviewed changes
maps/away/away_site/zavod_shuttle_destroyed/zavod_shuttle_destroyed.dm Outdated

sectors = list(ALL_POSSIBLE_SECTORS)
spawn_weight = 1
spawn_cost = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be = 1

@DreamySkrell
Copy link
Contributor

image
wrong exterior space turf
is /turf/space
should be /turf/template_noop

@DreamySkrell
Copy link
Contributor

image
atmos test fail here
this room has air and is exposed to space

DreamySkrell
DreamySkrell reviewed May 2, 2024
View reviewed changes
maps/away/away_site/zavod_shuttle_destroyed/zavod_shuttle_destroyed.dm Outdated

/area/zavod_shuttle_destroyed
name = "destroyed zavod shuttle"
requires_power = FALSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= TRUE

DreamySkrell
DreamySkrell requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@DreamySkrell DreamySkrell added the Changes Required The PR requires changes before it can be approved and/or merged. label May 2, 2024
@CactusMouth
Copy link
Contributor Author

I'll get it fixed in a moment

@CactusMouth
Copy link
Contributor Author

as above

Fixed.

@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label May 6, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue May 12, 2024
Merged via the queue into Aurorastation:master with commit 1d257c0 May 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DreamySkrell DreamySkrell DreamySkrell approved these changes

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

Assignees
No one assigned
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CactusMouth @DreamySkrell @NonQueueingMatt @BotBOREALIS