Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weakened hivebot beacon from golden slime #20163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlaunusLux
Copy link
Contributor

@AlaunusLux AlaunusLux commented Nov 13, 2024

In round cwE-dDLE a "dilapidated hivebot beacon" was summoned by gold slime cores. It was invisible and continuously summoned hivebots. This prevents it from being summoned by the gold slime cores.

For ease of reference, the weakened hivebot beacon is here:

/mob/living/simple_animal/hostile/hivebotbeacon/weakened

@AlaunusLux
Copy link
Contributor Author

!bugfix

@BotBOREALIS BotBOREALIS added the Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. label Nov 13, 2024
@AlaunusLux
Copy link
Contributor Author

!review

Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is to fix the weakened hivebot beacon if it's invisible or has some issue, not to remove it

@AlaunusLux
Copy link
Contributor Author

AlaunusLux commented Nov 13, 2024

As the other beacons are excluded from being summoned, and this beacon is in a different file, I assumed it was overlooked and needed to be removed from the list regardless of what caused its invisibility. Especially given that local testing shows neither manually spawning or using the golden slime core replicates the bug, I thought this was the best way to keep it from being an issue admins spend 30 minutes on in the future.

If you know what caused the invisibility issue or how to fix it, let me know. If you don't and don't want to remove this beacon from the summon list in the mean time, close the pull request.

@FluffyGhoster
Copy link
Contributor

As the other beacons are excluded from being summoned, and this beacon is in a different file, I assumed it was overlooked and needed to be removed from the list regardless of what caused its invisibility. Especially given that local testing shows neither manually spawning or using the golden slime core replicates the bug, I thought this was the best way to keep it from being an issue admins spend 30 minutes on in the future.

If you know what caused the invisibility issue or how to fix it, let me know. If you don't and don't want to remove this beacon from the summon list in the mean time, close the pull request.

Check the icon_state if it exists in the file, that's usually the reason when it's invisible

@AlaunusLux
Copy link
Contributor Author

AlaunusLux commented Nov 13, 2024

As I said, local testing does not replicate the issue. It inherits the icon and icon_state from the parent /mob/living/simple_animal/hostile/hivebotbeacon and is fully visible, and also gets destroyed properly when damaged enough.

@FluffyGhoster
Copy link
Contributor

As I said, local testing does not replicate the issue. It inherits the icon and icon_state from the parent /mob/living/simple_animal/hostile/hivebotbeacon and is fully visible, and also gets destroyed properly when damaged enough.

I misread what you wrote, then I do not know why it would be bugged when it happened

@AlaunusLux
Copy link
Contributor Author

#20166

I opened a bug report for the invisibility issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants