Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tosin/linter fix #631

Open
wants to merge 8 commits into
base: gh-pages
Choose a base branch
from
Open

Tosin/linter fix #631

wants to merge 8 commits into from

Conversation

midastouchprd
Copy link

@midastouchprd midastouchprd commented Sep 19, 2018 •
edited
Loading

Fix the linter so there is this output

===================CSS ERRORS START======================
===================CSS ERRORS START======================

01week/helloworld/css/style.css
 2:5  ✖  Expected indentation of 2 spaces   indentation

===================CSS ERRORS END======================
===================CSS ERRORS END======================


===================JS ERRORS START======================
===================JS ERRORS START======================

/Users/midastouch/Software/web-workbook/10week/bio-part-2/js/script.js
  1:10  error  Parsing error: Unexpected token (

✖ 1 problem (1 error, 0 warnings)

===================JS ERRORS END======================
===================JS ERRORS END======================


===================HTML ERRORS START======================
===================HTML ERRORS START======================
index.html: line 3, col 1, only <head> and <body> may be children of <html>

[htmllint] found 1 errors out of 4 files
===================HTML ERRORS END======================
===================HTML ERRORS END======================

@midastouchprd
Copy link
Author 

> [email protected] lint /Users/midastouch/Software/web-workbook
> sh lint_script.sh

==============CSS ERRORS===============
==============CSS ERRORS===============


==============CSS ERRORS===============
==============CSS ERRORS===============


==============JS ERRORS===============
==============JS ERRORS===============


==============JS ERRORS===============
==============JS ERRORS===============


==============HTML ERRORS===============
==============HTML ERRORS===============


[htmllint] found 0 errors out of 4 files

==============HTML ERRORS===============
==============HTML ERRORS===============

Congrats you've fixed all errors

^^ THIS IS THE CLEAN OUTPUT NOW

And failures won't stop all of them from continuing to run but any failure will still fail circle ci

@kevincolten
Copy link
Member

cc @CLofton

Thanks for doing this, this came out really nice and I hate how you have to run the linter multiple times to squeeze all the errors out. I'm afraid Windows users won't be able to use it out-of-the-box since it's bash and we try to keep it as "bash emulator optional" as possible, I'd even like to remove Git Bash from the environment setup and use Chocolately to install git, that way windows students can get comfortable in their native PowerShell.

What we can do with this is either move it directly into the CircleCI yaml config and/or convert it into a node script that'll be smart enough to use the proper OS commands.

We are working on the new version of this curriculum and workbook that will include unit (mocha or jest) + jsdom tests for some node and DOM apps, I wonder if we shouldn't just bring in a task runner like Gulp to try to keep it all node so it'll be more portable across all OS's and we won't have to always pray the package creators built all options into the CLI wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincolten kevincolten Awaiting requested review from kevincolten

Assignees
No one assigned
Labels
Austin Instructor Pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midastouchprd @kevincolten