Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to PyDicer class and add some docs #157

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add functions to PyDicer class and add some docs #157

merged 1 commit into from
Nov 17, 2023

Conversation

pchlap
Copy link
Contributor

@pchlap pchlap commented Nov 15, 2023

Hi @dalmouiee,

just adding some commonly used functions to the PyDicer class here to make them more accessible. Also have added some docs to be rendered by sphinx. Thanks.

@pchlap pchlap requested a review from dalmouiee November 15, 2023 04:21
dalmouiee
dalmouiee approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@dalmouiee dalmouiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @pchlap! Happy for a merge :)

@pchlap pchlap merged commit beca197 into main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalmouiee dalmouiee dalmouiee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchlap @dalmouiee