Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-to setpoint type #4

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Go-to setpoint type #4

merged 3 commits into from
Dec 15, 2023

Conversation

tstastny
Copy link
Contributor

@tstastny tstastny commented Nov 17, 2023

Adds a "Go-to" setpoint type which streams a position and (optional) heading setpoint, meant to be handled by a position and heading smoother on the flight controller. Main idea: dump in whatever position and heading you want, and they will be smoothly followed by the autopilot. Additional fields for velocity and heading rate limits are included.

An example mode using the Go-to setpoint type is included:
https://github.com/Auterion/px4-ros2-interface-lib/assets/8026163/76795ebc-13b9-4637-b7f7-867e773047fa

Depends on: PX4/PX4-Autopilot#22375

Docs: PX4/PX4-user_guide#2935

@tstastny tstastny added the enhancement New feature or request label Nov 17, 2023
@tstastny tstastny self-assigned this Nov 17, 2023
@tstastny tstastny changed the title Goto setpoint Go-to setpoint type Nov 17, 2023
@tstastny tstastny requested a review from bkueng November 23, 2023 18:47
@tstastny tstastny marked this pull request as ready for review November 23, 2023 18:47
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can also make the attitude & conversions generally available later on.

examples/cpp/modes/goto/include/mode.hpp Show resolved Hide resolved
examples/cpp/modes/goto/include/util.hpp Show resolved Hide resolved
examples/cpp/modes/goto/include/mode.hpp Outdated Show resolved Hide resolved
@tstastny
Copy link
Contributor Author

tstastny commented Dec 14, 2023

@bkueng i made quick minimal changes - but the rest i think we just do in a follow up to enable folks quickly on a working example for goto, ok for you?

@bkueng bkueng force-pushed the goto-setpoint branch 2 times, most recently from 962d7ed to 710896e Compare December 15, 2023 07:27
Thomas Stastny and others added 2 commits December 15, 2023 08:47
@bkueng bkueng merged commit cb5c099 into main Dec 15, 2023
8 checks passed
@bkueng bkueng deleted the goto-setpoint branch December 15, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants