fix(s3stream): remove future before complete it to prevent infinite r… (

#830) Signed-off-by: Shichao Nie <[email protected]>
AutoMQ · Dec 13, 2023 · d1cdb6b · d1cdb6b
1 parent 72d34d8
commit d1cdb6b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/s3stream/src/main/java/com/automq/stream/s3/cache/StreamReader.java b/s3stream/src/main/java/com/automq/stream/s3/cache/StreamReader.java
@@ -422,14 +422,14 @@ CompletableFuture<Void> getDataBlockIndices(long streamId, long endOffset, ReadC
     }
 
     private void completeInflightTask(DefaultS3BlockCache.ReadAheadTaskKey key, Throwable ex) {
-        inflightReadAheadTaskMap.computeIfPresent(key, (k, v) -> {
+        CompletableFuture<Void> cf = inflightReadAheadTaskMap.remove(key);
+        if (cf != null) {
             if (ex != null) {
-                v.completeExceptionally(ex);
+                cf.completeExceptionally(ex);
             } else {
-                v.complete(null);
+                cf.complete(null);
             }
-            return null;
-        });
+        }
     }
 
     private List<Pair<ObjectReader, StreamDataBlock>> collectStreamDataBlocksToRead(ReadContext context) {