Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize S3Utils output #893

Closed
wants to merge 3 commits into from
Closed

chore: optimize S3Utils output #893

wants to merge 3 commits into from

Conversation

KaimingWan
Copy link
Contributor

Give a more readable output of check message like :

[ OK ] Write s3 object
[ OK ] Read s3 object
[ OK ] Delete s3 object
[ OK ] Write S3 object
[ OK ] Upload s3 multipart object
[ OK ] Read s3 multipart object
[ OK ] Delete s3 object

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2024

CLA assistant check
All committers have signed the CLA.

@KaimingWan KaimingWan changed the title optimize the output of S3Utils to support automq admin tool chore(tool): optimize the output of S3Utils to support automq admin tool Jan 12, 2024
@KaimingWan KaimingWan changed the title chore(tool): optimize the output of S3Utils to support automq admin tool chore: optimize the output of S3Utils to support automq admin tool Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87098f5) 54.98% compared to head (f88e9d1) 55.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #893      +/-   ##
============================================
+ Coverage     54.98%   55.01%   +0.03%     
- Complexity     1243     1246       +3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4692     4695       +3     
  Misses         3425     3425              
+ Partials        417      414       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

} else {
System.err.println("get other exception: ");
e.printStackTrace();
System.out.println("get other exception: ");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing err to out?

Copy link
Contributor Author

@KaimingWan KaimingWan Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mooc9988
Admin tool now disable system.err to suppress the slf4j inner warn log like this:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/admin/.m2/repository/org/slf4j/slf4j-log4j12/1.6.4/slf4j-log4j12-1.6.4.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/admin/.m2/repository/org/slf4j/slf4j-log4j12/1.6.1/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.

So, if S3Utils use system.err to print error message, admin tool can't see them.

@KaimingWan KaimingWan changed the title chore: optimize the output of S3Utils to support automq admin tool chore: optimize S3Utils output Jan 12, 2024
@KaimingWan KaimingWan closed this Jan 12, 2024
@Chillax-0v0 Chillax-0v0 deleted the chore/admin_tool branch February 20, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants