-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: optimize S3Utils output #893
Conversation
… this to avoid slf4j's inner warning logs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
============================================
+ Coverage 54.98% 55.01% +0.03%
- Complexity 1243 1246 +3
============================================
Files 133 133
Lines 8534 8534
Branches 789 789
============================================
+ Hits 4692 4695 +3
Misses 3425 3425
+ Partials 417 414 -3
|
} else { | ||
System.err.println("get other exception: "); | ||
e.printStackTrace(); | ||
System.out.println("get other exception: "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing err to out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mooc9988
Admin tool now disable system.err to suppress the slf4j inner warn log like this:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/admin/.m2/repository/org/slf4j/slf4j-log4j12/1.6.4/slf4j-log4j12-1.6.4.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/admin/.m2/repository/org/slf4j/slf4j-log4j12/1.6.1/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
So, if S3Utils use system.err to print error message, admin tool can't see them.
Give a more readable output of check message like :