-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(s3stream): optimize StreamRecordBatchList to reduce object creation #903
perf(s3stream): optimize StreamRecordBatchList to reduce object creation #903
Conversation
lifepuzzlefun
commented
Jan 28, 2024
•
edited
Loading
edited
- remove ArrayList copy when create instance.
- StreamRecordBatch will implement the ComparableItem interface without create wrap object.
Hi @lifepuzzlefun thanks for your contribution. And, please check the failed actions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
============================================
+ Coverage 55.90% 55.91% +0.01%
- Complexity 1264 1266 +2
============================================
Files 133 133
Lines 8534 8534
Branches 789 789
============================================
+ Hits 4771 4772 +1
Misses 3327 3327
+ Partials 436 435 -1
|
LGTM, @lifepuzzlefun the commit msg lint seems failed, maybe rebase & rewrite the commit msg to something like: perf(s3stream): optimize StreamRecordBatchList
|
...eam/src/main/java/com/automq/stream/utils/biniarysearch/primitive/LongOrderedCollection.java
Outdated
Show resolved
Hide resolved
@lifepuzzlefun You can use
(e5e2080 is the first commit hash in your branch, and a '^' means the commit before the specified commit) |
1. remove ArrayList copy when create instance. 2. only create ComparableStreamRecordBatch when call get. 3. reduce java primitive type compare for Long.
004b110
to
7087857
Compare
80cfc03
to
03497d9
Compare
1. remove ArrayList copy when create instance. 2. only create ComparableStreamRecordBatch when call get. 3. reduce java primitive type compare for Long.
03497d9
to
3bbd770
Compare
@SCNieh @Chillax-0v0 thanks for help. the commit message has been modified, hope the CI can pass. by the way, I think we need update the contribute guide to tell the contributors write commit message in the expected format. |
We will merge the PR in a squash manner, so we don't need to modify the commit message one by one, just squashing all the commits to one commit is enough. Anyway, I will remove the |