Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid use jdk api upper jdk11 #905

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

lifepuzzlefun1
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2024

CLA assistant check
All committers have signed the CLA.

@daniel-y
Copy link
Contributor

Great catch, the gradle/maven failed to check the API level compatibility. Could you please check the failed actions, it seems that you should follow the checkstyle here: https://github.com/AutoMQ/automq-for-rocketmq/blob/main/style/rmq_checkstyle.xml

@lifepuzzlefun1 lifepuzzlefun1 changed the title fix: avoid use jdk api upper jdk11 refactor: avoid use jdk api upper jdk11 Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c41351) 55.96% compared to head (370c388) 55.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #905      +/-   ##
============================================
- Coverage     55.96%   55.90%   -0.06%     
+ Complexity     1267     1265       -2     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
- Hits           4776     4771       -5     
- Misses         3324     3327       +3     
- Partials        434      436       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (-0.11%) ⬇️
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.60% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@daniel-y
Copy link
Contributor

@ShadowySpirits the S3Stream E2E failed, please have a check.

@daniel-y daniel-y force-pushed the fix_java_11_require branch from 9302283 to 370c388 Compare January 29, 2024 08:32
@daniel-y daniel-y merged commit 5cbd19c into AutoMQ:main Jan 29, 2024
5 of 6 checks passed
lifepuzzlefun pushed a commit to lifepuzzlefun/automq-for-rocketmq that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants