Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): confirm requests after putting them into logCache #961

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

@Chillax-0v0 Chillax-0v0 requested a review from superhx March 12, 2024 12:59
@Chillax-0v0 Chillax-0v0 self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (ebf8257) to head (308fa97).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #961      +/-   ##
============================================
- Coverage     55.90%   54.99%   -0.92%     
+ Complexity     1264     1244      -20     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
- Hits           4771     4693      -78     
- Misses         3327     3425      +98     
+ Partials        436      416      -20     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (-2.81%) ⬇️
RocketMQ Proxy 37.18% <ø> (ø)
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 16 files with indirect coverage changes

@superhx superhx merged commit 9182360 into main Mar 13, 2024
8 checks passed
@superhx superhx deleted the fix-s3stream-confirm-after-put-to-log-cache branch March 13, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants