fix(s3stream): release buffer on exception when compacting stream obj…

…ects (#1322) Signed-off-by: Shichao Nie <[email protected]>
AutoMQ · May 30, 2024 · 6f0bd74 · 6f0bd74
1 parent 8585ffa
commit 6f0bd74
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/s3stream/src/main/java/com/automq/stream/s3/StreamObjectCompactor.java b/s3stream/src/main/java/com/automq/stream/s3/StreamObjectCompactor.java
@@ -221,6 +221,11 @@ public Optional<CompactStreamObjectRequest> compact() throws ExecutionException,
                     objectSize += basicObjectInfo.dataBlockSize() - validDataBlockStartPosition;
                     indexes.addComponent(true, subIndexes);
                     compactedObjectIds.add(object.objectId());
+                } catch (Throwable t) {
+                    LOGGER.error("[COPY_WRITE_FAILED] streamId={}, objectId={}, {}", streamId, object.objectId(), t.getMessage());
+                    indexes.release();
+                    writer.release();
+                    throw t;
                 }
             }
             if (lastIndex != null) {