Fixed distribute and post processing bugs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsalehipour
requested changes
Aug 2, 2024
examples/cfd/windtunnel_3d.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| from math import e | |||
Comment on lines
+116
to
+117
| distributed_op = distribute_operator( | ||
| operator, grid, velocity_set, num_results=num_results, ops=ops |
There was a problem hiding this comment.
Please move this to be the defaul results outside of the if statement and deleve else of the inner if statement.
There was a problem hiding this comment.
there is no need to spend time compiling a stepper that we won't need in the future. It's already the default behavior.
| f_post_collision = self.collision.warp_functional(f_post_stream, feq, rho, u) | ||
| f_post_collision = self.collision.warp_functional( | ||
| f_post_stream, feq, rho, u | ||
| ) |
There was a problem hiding this comment.
Please don't use the formatter in your PRs where the focus is not the formatting.
There was a problem hiding this comment.
Merge this. I am setting up ruff for the project. The reason of this change was the ruff was not respected in previous PRs.
mehdiataei
force-pushed
the
major-refactoring
branch
from
1a01139
to
3db2c66
Compare
mehdiataei
force-pushed
the
major-refactoring
branch
from
3db2c66
to
1810e9c
Compare
hsalehipour
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.