A stable and robust BC added for stationary and moving curved BCs #68
+826
−237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a stable and robust BC for stationary and moving curved BCs which is a hybrid between differentiable interpolated bouceback and the Grads Approximation and the Regularization methods. Preliminary tests indicate stable resutls for exceedingly high Re values using the wind tunnel example.
Added a new boundary masker that also provides fractional distance to the mesh used in the above boundary for curved geometries.
Made major changes to the inputs and outputs of BC functionals by passing in entire f_0 and f_1 fields as well as the index. So all the auxiliary data are now build and constructed (if needed) inside the BC class.
The above change coincidently removed the perf drop experienced by going from Warp 1.3 to 1.4
Existing Perf Drop: I am seeing about 38%!!! perf drop (2780 vs 4448 MLUPS) due to these 3 lines in nse_stepper.py using Warp 1.4 on my A6000 GPU!