HYDRA-686 : Fix manual lifetime management of MayaHydraSceneIndex's adapters #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debloip-adsk
commented
Aug 27, 2024
| TF_AXIOM(MayaHydra::PickHandlerRegistry::Instance().Unregister(_rprimPath)); | ||
| } | ||
|
|
||
| void MayaHydraSceneIndex::RemoveCallbacksAndDeleteAdapters() |
There was a problem hiding this comment.
Moved the body of RemoveCallbacksAndDeleteAdapters into the destructor itself, so we no longer need to make that manual call to cleanup the MayaHydraSceneIndex.
|
No test added; the original issue was already detected by existing tests, and there is also already a test that switches between MayaHydra and VP2 to test MayaHydra setup and cleanup behaviors. |
lanierd-adsk
previously approved these changes
Aug 28, 2024
debloip-adsk
added
the
ready-for-merge
debloip-adsk
removed
the
ready-for-merge
lanierd-adsk
approved these changes
Sep 4, 2024
debloip-adsk
added
the
ready-for-merge
debloip-adsk
deleted the
debloip/HYDRA-686/fix-adapters-manual-lifetime-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.