EMSUSD-972 refactor duplication code #3573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make the duplication more testable.
Some scenarios would require the Arnold plugin to be present and we want to avoid depending on it. So instead, the code refactor split the duplication into finer-grained functions that can be tested by using custom-made temporary layers to reproduce the behavior of Arnold.
The refactor also makes the code clearer and more correct by having smaller functions. Multiple subtle problems were discovered and fixed with this strategy, related to complex cases of renaming and inter-prim relationships.