Skip to content

Conversation

@sankalps0549
Copy link
Collaborator

Description

This PR introduces the integration tests for the Synergy class.

Changes in this PR:

  • Added new models in study_files folder
  • Updated data folder with synergy_data file
  • Added test_integration_synergy.py
  • Updated integration_tests\conftest.py file
  • Added synergy pytest marker to the test_unit_synergy.py class

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added a note to CHANGELOG.md describing my changes
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Testing

Added Integration Tests for the ImportOptions class

python run.py test -m synergy

Test Data Generation

python run.py generate-test-data synergy

Test Run:

image image image image

Additional Notes

N/A

@sankalps0549 sankalps0549 requested a review from Copilot November 4, 2025 18:51
@sankalps0549 sankalps0549 self-assigned this Nov 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive integration tests for the Synergy class, validating its core functionality with real Moldflow Synergy COM objects. The tests verify Synergy properties, project operations, file imports, window positioning, and creation of various helper classes.

Key changes:

  • New integration test suite covering Synergy initialization, properties, project operations, and helper object creation
  • Added test data generation capability for Synergy-specific properties (version, build number)
  • Included Single study file set for quick test execution
  • Updated conftest.py to support Synergy tests without requiring project/study fixtures

Reviewed Changes

Copilot reviewed 22 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test_integration_synergy.py New comprehensive integration tests for Synergy class covering 11 test methods across 3 test classes
test_synergy.py Removed old basic Synergy test file
test_unit_synergy.py Added synergy pytest marker for targeted test execution
synergy_data.json New test data file containing expected version and build number
generate_data.py Added generate_synergy_data function to create test data
generate_data_helper.py Refactored to handle data generation without file sets
constants.py Added Synergy-specific constants including window positioning defaults and file paths
conftest.py Enhanced with temp_dir fixture, Single file set support, and expected_values_general fixture
study_files/Single/* Added Single study file set with pre-analyzed DOE model for quick testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sankalps0549 sankalps0549 requested a review from Copilot November 4, 2025 19:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 28 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

assert isinstance(result, MaterialSelector)
assert result.material_selector is not None

# TODO: open_archive
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added in the future, after some more clarification on allowed extension types.

@sankalps0549 sankalps0549 marked this pull request as draft November 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants