-
Notifications
You must be signed in to change notification settings - Fork 1
Synergy Class Integration Tests #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/integration-tests
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive integration tests for the Synergy class, validating its core functionality with real Moldflow Synergy COM objects. The tests verify Synergy properties, project operations, file imports, window positioning, and creation of various helper classes.
Key changes:
- New integration test suite covering Synergy initialization, properties, project operations, and helper object creation
- Added test data generation capability for Synergy-specific properties (version, build number)
- Included Single study file set for quick test execution
- Updated conftest.py to support Synergy tests without requiring project/study fixtures
Reviewed Changes
Copilot reviewed 22 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test_integration_synergy.py | New comprehensive integration tests for Synergy class covering 11 test methods across 3 test classes |
| test_synergy.py | Removed old basic Synergy test file |
| test_unit_synergy.py | Added synergy pytest marker for targeted test execution |
| synergy_data.json | New test data file containing expected version and build number |
| generate_data.py | Added generate_synergy_data function to create test data |
| generate_data_helper.py | Refactored to handle data generation without file sets |
| constants.py | Added Synergy-specific constants including window positioning defaults and file paths |
| conftest.py | Enhanced with temp_dir fixture, Single file set support, and expected_values_general fixture |
| study_files/Single/* | Added Single study file set with pre-analyzed DOE model for quick testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 28 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| assert isinstance(result, MaterialSelector) | ||
| assert result.material_selector is not None | ||
|
|
||
| # TODO: open_archive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be added in the future, after some more clarification on allowed extension types.
Description
This PR introduces the integration tests for the
Synergyclass.Changes in this PR:
study_filesfolderdatafolder withsynergy_datafiletest_integration_synergy.pyintegration_tests\conftest.pyfilesynergypytest marker to thetest_unit_synergy.pyclassType of change
Please delete options that are not relevant.
Checklist
Please delete options that are not relevant.
Testing
Added Integration Tests for the ImportOptions class
Test Data Generation
Test Run:
Additional Notes
N/A