Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed get_template_directory_uri function with get_theme_file_uri #1142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vinoddalvi
Copy link
Contributor

No description provided.

@davidakennedy
Copy link
Contributor

Hi @vinoddalvi! Thank you for the pull request!

In the future, please try to include some kind of description with pull requests. Even simple things. It makes it easier for maintainers to review issues and PRs in order to make decision. I'd also say that a well written issue or PR description is just as valuable as code – sometimes more so. 😄

That said, with this feature having launched in 4.7, we should probably wait until 4.9 comes out or do some kind of check to fall back if the function isn't available. Historically, we've tried to support WordPress versions two versions back from the current one in _s.

We should also think about the get_theme_file_path() function as well, and look to Twenty Seventeen for the lead here. See this post for more information.

@vinoddalvi
Copy link
Contributor Author

@davidakennedy Thank you for your kind reply and sure i will add description in the PR henceforward.

@zimnyd
Copy link

zimnyd commented Jul 29, 2020

Will this change be implemented in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants