Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node to version 20 #340

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update node to version 20 #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8268a9
Update node to version 20
fluiddot Dec 21, 2023
6a4f925
Update `@wordpress/scripts` dependency to latest version
fluiddot Dec 21, 2023
76a11d9
Update dependencies to their latest version based on their version range
fluiddot Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.17.0
20
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@wordpress/icons": "^6.1.1",
"@wordpress/jest-preset-default": "^7.1.3",
"@wordpress/prettier-config": "^1.1.1",
"@wordpress/scripts": "^19.2.3",
"@wordpress/scripts": "^26.19.0",
Copy link
Author

@fluiddot fluiddot Dec 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear the potential side-effects of updating this package. The fact that this repository doesn't have CI checks gives low confidence in introducing changes. In any case, I presume that this package is mainly used for the development workflow, so probably won't introduce regressions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each plugin is manually released separately, so there at least wouldn't be any immediate problems if one of them no longer builds properly.

I ran yarn everything to build all the plugins, and didn't see any issues that didn't exist before this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you very much @ajlende for the information and for checking that all plugins can be built 🙇 .

"autoprefixer": "^10.4.2",
"blockbook-cli": "^0.7.0",
"eslint": "^8.7.0",
Expand Down
Loading