-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gutenberg 17 #253
Conversation
As setupEditorState is deprecated
Which is actually a false positive, which is weird
So we can finish the build in a reasonable time
7b19e57
to
13570cf
Compare
We don’t want these going out so short circuit them
I don’t have the patience to figure out the right selector!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR as it's been tested as part of https://github.com/Automattic/p2/pull/6285. See the approval comment there.
@johngodley @fjorgemota Happy to help push this forward, let me know, and I can deploy this package and the new P2 version (https://github.com/Automattic/p2/pull/6285) at some point tomorrow if you don't beat me to it. |
To match the new React 18 API.
d06ae50
to
b1241a0
Compare
Just a note that this is a public repo, so references to P2 shouldn't really be here! Instead it's better to refer from P2 |
Related to: https://github.com/Automattic/p2/pull/6285.
Updates packages to match the ones from GB 17+ in order to fix issues and unblock the usage of Gutenberg 17.9 in the P2 app, via the
isolated-block-editor
.You should test with a P2 as a consumer. To do that:
plugins/p2/package.json
'sisolated-block-editor
to point to this branch:Alternatively, you can follow the instructions at the bottom of https://github.com/Automattic/p2/pull/6285 and sync the diffs instead.