Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gutenberg 17 #253

Merged
merged 26 commits into from
Mar 21, 2024
Merged

Update to Gutenberg 17 #253

merged 26 commits into from
Mar 21, 2024

Conversation

fjorgemota
Copy link
Member

@fjorgemota fjorgemota commented Feb 15, 2024

Related to: https://github.com/Automattic/p2/pull/6285.

Updates packages to match the ones from GB 17+ in order to fix issues and unblock the usage of Gutenberg 17.9 in the P2 app, via the isolated-block-editor.

You should test with a P2 as a consumer. To do that:

  1. Checkout P2 from the following branch: https://github.com/Automattic/p2/pull/6285.
  2. Change plugins/p2/package.json's isolated-block-editor to point to this branch:
"@automattic/isolated-block-editor": "github:Automattic/isolated-block-editor#update/gutenberg-17",
  1. Build and sync P2 to the sandbox.

Alternatively, you can follow the instructions at the bottom of https://github.com/Automattic/p2/pull/6285 and sync the diffs instead.

  1. Sandbox a test P2 to your sandbox;
  2. Now test the editor there. Make sure to smoke test and that the following issues are not happening anymore:

@fjorgemota fjorgemota self-assigned this Feb 15, 2024
@fullofcaffeine fullofcaffeine marked this pull request as ready for review March 20, 2024 22:41
Copy link
Contributor

@fullofcaffeine fullofcaffeine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR as it's been tested as part of https://github.com/Automattic/p2/pull/6285. See the approval comment there.

@fullofcaffeine
Copy link
Contributor

@johngodley @fjorgemota Happy to help push this forward, let me know, and I can deploy this package and the new P2 version (https://github.com/Automattic/p2/pull/6285) at some point tomorrow if you don't beat me to it.

@johngodley johngodley merged commit 8ffe060 into trunk Mar 21, 2024
1 check passed
@johngodley johngodley deleted the update/gutenberg-17 branch March 21, 2024 08:22
@johngodley
Copy link
Member

Just a note that this is a public repo, so references to P2 shouldn't really be here! Instead it's better to refer from P2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants