Skip to content

Commit

Permalink
Use constants for layout names
Browse files Browse the repository at this point in the history
  • Loading branch information
simison committed Feb 17, 2020
1 parent 500bc77 commit 3b39465
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions extensions/blocks/tiled-gallery/layout/mosaic/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Gallery from '../gallery';
import Row from '../row';
import { getGalleryRows, handleRowResize } from './resize';
import { imagesToRatios, ratiosToColumns, ratiosToMosaicRows } from './ratios';
import { LAYOUT_COLUMN, LAYOUT_STACKED } from '../../constants';

export default class Mosaic extends Component {
gallery = createRef();
Expand All @@ -29,7 +30,10 @@ export default class Mosaic extends Component {
componentDidUpdate( prevProps ) {
if ( prevProps.images !== this.props.images || prevProps.align !== this.props.align ) {
this.triggerResize();
} else if ( 'columns' === this.props.layoutStyle && prevProps.columns !== this.props.columns ) {
} else if (
LAYOUT_COLUMN === this.props.layoutStyle &&
prevProps.columns !== this.props.columns
) {
this.triggerResize();
}
}
Expand Down Expand Up @@ -80,9 +84,9 @@ export default class Mosaic extends Component {
render() {
const { align, columns, images, layoutStyle, renderedImages } = this.props;

const columnsToRender = 'stacked' === layoutStyle ? 1 : columns;
const columnsToRender = LAYOUT_STACKED === layoutStyle ? 1 : columns;
const ratios = imagesToRatios( images );
const rows = [ 'columns', 'stacked' ].includes( layoutStyle )
const rows = [ LAYOUT_COLUMN, LAYOUT_STACKED ].includes( layoutStyle )
? ratiosToColumns( ratios, columnsToRender )
: ratiosToMosaicRows( ratios, { isWide: [ 'full', 'wide' ].includes( align ) } );

Expand Down

0 comments on commit 3b39465

Please sign in to comment.