Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Cache: be more defensive when fetching promo links #34962

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 11, 2024

Fixes #34960

Proposed changes:

Avoid trying to fetch specific links when the global is not set.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

I could not replicate the original issue on my end, but submitted this PR based off the info in the original issue, #34960.

It turns out this is not solving their issue, so may not be necessary.

Fixes #34960

Avoid trying to fetch specific links when the global is not set.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Pri] Low [Focus] Compatibility Ensuring our products play well with third-parties labels Jan 11, 2024
@jeherve jeherve requested a review from donnchawp January 11, 2024 14:03
@jeherve jeherve self-assigned this Jan 11, 2024
@github-actions github-actions bot added the [Plugin] Super Cache A fast caching plugin for WordPress. label Jan 11, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: February 6, 2024.
  • Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not really needed, but of course, since $wpsc_promo_links is a global variable, there's always a chance it might be modified elsewhere.

@jeherve jeherve merged commit 51c4b5c into trunk Jan 16, 2024
56 checks passed
@jeherve jeherve deleted the fix/super-cache-url-warnings branch January 16, 2024 15:11
@github-actions github-actions bot added this to the super-cache/1.11.1 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Low [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning in WP-CLI on PHP 8.2
3 participants