-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack SEO Assistant: add steps codependency flow #41341
Jetpack SEO Assistant: add steps codependency flow #41341
Conversation
…pped and the current value of it
… based on previous step skip and value conditions
…based on previous step skip condition
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 5 files.
|
Fixes #41070
Proposed changes:
This PR changes the step's start handler to allow passing previous step's status and values.
It allows for a more cohesive composing, adding the ability to edit messages and concat messages to achieve desired chat flow.
Other information:
Jetpack product discussion
pe4Cmx-2ZI-p2
p1HpG7-vtt-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Complete the first "one click connect" to Jetpack.
Add "Code Snippets" plugin and add the filter on a snippet (save & activate):
Head to the editor and you should see the SEO panel on Jetpack Sidebar. Enable SEO module from there and the assistant trigger should be available.
Observe the flow and messages on each step. Skipping and regenerating should now work as in the designs.
See that keywords can be submitted with Enter key