Skip to content

Forms: Save to new format #44659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Forms: Save to new format #44659

wants to merge 2 commits into from

Conversation

enejb
Copy link
Member

@enejb enejb commented Aug 6, 2025

Fixes #

Proposed changes:

  • Updates the processing function to save everything in a new format.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Do the tests pass?

  • Add a form with all the fields.
  • Save the form.
    Does it still work as expected?
    Is the form saved?
    Do you get an email.
    Can you export the new feedback?
    Can you see it in the dashboard as expected?

enejb added 2 commits August 5, 2025 19:22
@enejb
Refactor contact form to use Feedback object for data handling
dc03ad3 
Refactored the contact form processing to delegate field extraction, subject, consent, and Akismet variable generation to the Feedback object. Updated email resending and legacy field parsing to use Feedback methods. Added new methods to Feedback for retrieving legacy and extra values. Updated tests to assert against Feedback object methods instead of raw post content. This improves code maintainability and encapsulation of feedback data.
@enejb
changelog
ddc4980
@enejb enejb requested a review from a team August 6, 2025 13:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-save-to-new-format branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-save-to-new-format

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 6, 2025
@jp-launch-control JP Launch Control
Copy link

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 396/1180 (33.56%) -2.81% 30 💔
projects/packages/forms/src/contact-form/class-feedback.php 340/369 (92.14%) -4.18% 16 💔
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php 461/539 (85.53%) 0.63% -4 💚
projects/packages/forms/src/contact-form/class-contact-form.php 560/1039 (53.90%) -2.49% -26 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@enejb enejb mentioned this pull request Aug 6, 2025
Closed
3 tasks
lezama
lezama reviewed Aug 6, 2025
View reviewed changes
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php
$to = $email['to'];
if ( ! empty( $comment_author_email ) ) {
$reply_to_addr = $comment_author_email;
} elseif ( is_array( $to ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enejb looks like Phan is right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I need to take another look at this. Will break this part up in it's own PR.

@enejb enejb mentioned this pull request Aug 6, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama left review comments

Assignees
No one assigned
Labels
[Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enejb @lezama