Skip to content

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented Oct 10, 2025

Proposed changes:

When you click the Install or Activate button to install or activate a plugin from our form integrations dashboard or modal, there's a bug where it goes into loading state, then returns to normal state once the plugin is installed, then disappears when we fetch integration status and find the plugin is installed.

This occurs because we're sending two separate requests - one to activate the plugin, and another to fetch integration status. The install button only shows loading state during the first.

I was going to fix this by showing button loading state when integrations are loading, but that would mean when you click to install one button, all the integrations buttons might suddenly show loading state, which is jarring.

So the fix just tracks a 'reconciling' status for the current component. We set that to true once a plugin is active, but we're awaiting integration data, and set it back to false when we get the updated integration status.

The result is the button just shows loading until it fully disappears.

Before
https://github.com/user-attachments/assets/ee5665c6-761d-43ca-ba17-d70bf42b7674

After
https://github.com/user-attachments/assets/a448dec8-352d-447f-ad8d-69335599124d

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Go to the forms dashboard. Install or activate a plugin. Confirm that the install/activate button doesn't re-show in normal active state before disappearing. It should just stay loading until it disappears.

@edanzer edanzer requested a review from a team October 10, 2025 20:11
@edanzer edanzer self-assigned this Oct 10, 2025
@edanzer edanzer added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal [Package] Forms labels Oct 10, 2025
@edanzer edanzer changed the title Forms: Fix plugin activation state Forms: Fix plugin button activating state Oct 10, 2025
@github-actions github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 10, 2025
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/form-plugin-install-load-state branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/form-plugin-install-load-state

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/components/jetpack-integrations-modal/integration-card/plugin-action-button.tsx 0/32 (0.00%) 0.00% 5 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great! :shipit:

@enejb
Copy link
Member

enejb commented Oct 10, 2025

Works well in my testing as well! nicely done

@edanzer edanzer merged commit ffa5839 into trunk Oct 13, 2025
72 of 74 checks passed
@edanzer edanzer deleted the fix/form-plugin-install-load-state branch October 13, 2025 16:07
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 13, 2025
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants