Skip to content

Conversation

@gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Nov 12, 2025

Fixes MYJP-272

Changes proposed in this Pull Request

Adds white background color to the modules list in My Jetpack → Products tab.

Why are these changes being made?

The modules list was missing the white background color that was specified in the Figma designs.

Testing instructions

  1. Navigate to My Jetpack → Products tab
  2. Verify that the modules list (table with module toggles) now has a white background
  3. Verify that the visual appearance matches the Figma designs linked in MYJP-272
CleanShot 2025-11-12 at 14 31 53@2x CleanShot 2025-11-12 at 14 29 02@2x

Does this pull request change what data or activity we track or use?

No

Jetpack product discussion

MYJP-272

@gmjuhasz gmjuhasz requested a review from a team November 12, 2025 13:37
@gmjuhasz gmjuhasz self-assigned this Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/myjp-products-list-missing-background branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/myjp-products-list-missing-background

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@gmjuhasz gmjuhasz added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Package] My Jetpack labels Nov 12, 2025
@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Package] My Jetpack labels Nov 12, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 12, 2025
@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit it looked white to me until I compared the fix. 😅

@gmjuhasz
Copy link
Contributor Author

I have to admit it looked white to me until I compared the fix. 😅

I know! First time I also could not find what the issue is 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants