feat: add semver range for mongodb node driver and bson versions #14916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
reviewed
Sep 28, 2024
There was a problem hiding this comment.
Looks good to me, though i think going this far is quite a substantial change, how about (at least until 9.0) allow all patch versions like ~6.9.0 instead of directly only 6.9.0? (though i am not familiar how heavy the performance degradation was between versions the versions in the mentioned issue)
|
It looks like we have an alternative fix for #14877 with mongodb/node-mongodb-native#4249, so we should instead just bump to Given that change, I think it is reasonable to make Mongoose 8.8 rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of hard-coding an exact version of the mongodb node driver, add a semver range. This should help with issues like #14877, where users want to use an older version of the mongodb node driver without downgrading Mongoose.
I also modified GitHub workflows to run tests against both the lowest mongodb node driver version in the semver range, and the latest version.
This is a fairly substantial change, I'll think about this some more over the weekend. Mongoose has pinned exact versions since before I became involved with the project, because historically Mongoose was a bit too tightly coupled to the MongoDB Node driver and patch releases in the MongoDB Node driver would create breaking changes in Mongoose on occasion. However, it has been years since we've seen that happen, both due to increased stability in the MongoDB Node driver and due to Mongoose no longer reaching into internal connection state regularly.
Examples