Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change nicename UI #3740

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Feat/change nicename UI #3740

wants to merge 4 commits into from

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Feb 10, 2025

All Submissions:

Changes proposed in this Pull Request:

This is an experimental UI to #3725.

This is not meant to be enabled for every user, but it can be enabled if there's a special need for this feature.

How to test the changes in this Pull Request:

  1. add define( 'NEWSPACK_CHANGE_NICENAME_UI', true );
  2. Edit a user
  3. Confirm there's a new section called "Change User archive URL"
  4. Check test instructions on feat: handle user nicename change #3725 and perform them, but using the UI this time

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 10, 2025
@leogermani leogermani self-assigned this Feb 10, 2025
@leogermani leogermani requested a review from a team as a code owner February 10, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant