replace useGoogleServicesDebugFile task with file in debug flavor #1434
Conversation
This accomplishes a few things: 1. Removes some entries in .gitleaksignore which were incorrect (the commit hash did not match the commit that introduced the change) 2. Moves our handling of the debug google services file to a gitleaks config file. That means that no matter where that secret shows up, it will be allowed (as opposed to handling it in the gitleaksignore file which required specifying every location/commit where the secret was introduced). 3. Adds the old IntentUtilTest example api key to the list of ignored secrets so that it does not get flagged up when running `gitleaks detect`.
Applying the same change that we did to the app module in e306375.
|
Thanks @eighthave ! This looks good. 👍 I pushed a few commits doing just a bit of housekeeping, and also extending this approach to the wear and automotive apps. Let me know if you have any thoughts about those updates. Since I've pushed some non-trivial changes, let me also ask @geekygecko and @ashiagr to take a look at this, particularly at the gitleaks change I made in fed547e. |
|
LGTM! |
It looks good to me. Should we comment on what the entries in allowlist -> regexes are? It took me a little while to realise it was the Google Services API key. |
Good idea @geekygecko . I added that in 95311e5. |
#1206 (comment)
Description
Simplify build flavor setup so that we can introduce a "free" flavor #1206
Based on this suggestion:
#1206 (comment)
This could additionally include the same changes to the "wear" and "automotive" flavors.
Testing Instructions
./gradlew build
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml