Refactor downloads deep linking #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
geekygecko
approved these changes
Jul 8, 2024
app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/TestActivity.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+15
to
+18
| data object DownloadsDeepLink : DeepLink { | ||
| override fun toIntent(context: Context) = context.launcherIntent | ||
| .setAction(ACTION_OPEN_DOWNLOADS) | ||
| } |
There was a problem hiding this comment.
Just an idea, but how about including the action name in the object as they are linked?
Suggested change
| data object DownloadsDeepLink : DeepLink { | |
| override fun toIntent(context: Context) = context.launcherIntent | |
| .setAction(ACTION_OPEN_DOWNLOADS) | |
| } | |
| data object DownloadsDeepLink : DeepLink { | |
| override fun action() = "INTENT_OPEN_APP_DOWNLOADING" | |
| override fun toIntent(context: Context) = context.launcherIntent | |
| .setAction(action()) | |
| } |
There was a problem hiding this comment.
I think I get the intention but it doesn't work well in my opinion. Some deep links are data classes and not data objects so action() cannot be invoked on them without instantiation. In that case adapters that create non-object deep links cannot access actions.
I could move all actions to objects and to companion objects for some better organization if you think it's worth it?
There was a problem hiding this comment.
No worries, thanks for considering it.
...services/deeplink/src/main/kotlin/au/com/shiftyjelly/pocketcasts/deeplink/DeepLinkFactory.kt
Outdated
Show resolved
Hide resolved
…ocketcasts/deeplink/DeepLinkFactory.kt Co-authored-by: Philip Simpson <[email protected]>
…tivity.kt Co-authored-by: Philip Simpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This will be a series of PRs that move deep linking to a separate module that can be tested. The goal is to fix #2405 but I don't want to do it blindly without having tests in order to not introduce regressions to deep linking.
This PR migrates deep linking of downloads to the new module.
Testing Instructions
Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApplyto automatically apply formatting/linting)All strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xmlAny jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.