Refactor bookmark delete deep linking #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mebarbosa
requested review from
a team and
mebarbosa
and removed request for
mebarbosa and
a team
|
I am removing myself from this PR review since I don't have headphones to test it @Automattic/pocket-casts-android |
mebarbosa
requested review from
geekygecko and
ashiagr
and removed request for
mebarbosa
ashiagr
approved these changes
Jul 8, 2024
MiSikora
force-pushed
the
task/bookmark-show-deep-linking
branch
from
e153599
to
b0ee92a
Compare
MiSikora
force-pushed
the
task/bookmark-delete-deep-link
branch
from
24f30cd
to
5a222e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This will be a series of PRs that move deep linking to a separate module that can be tested. The goal is to address #2405 but I don't want to do it blindly without having tests in order to not introduce regressions to deep linking.
This PR migrates deleting bookmark deep linking to the new module.
Testing Instructions
You can test it by assigning
Add bookmarkaction to your headphones, and then triggering it while the app is in background and choosingDeleteoption. If you can't test it this way do the following:adb shell am start -n au.com.shiftyjelly.pocketcasts.debug/au.com.shiftyjelly.pocketcasts.ui.MainActivity -a INTENT_OPEN_APP_DELETE_BOOKMARK -e bookmark_uuid <BOOKMARK_UUID>.Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApplyto automatically apply formatting/linting)All strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xmlAny jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.