Airtable Integration: Extract AirtableDatasource & leverage it for built-in & dynamic datasources #17
Conversation
| use RemoteDataBlocks\Logging\Logger; | ||
| use RemoteDataBlocks\Logging\LoggerManager; | ||
| use RemoteDataBlocks\REST\DatasourceCRUD; |
There was a problem hiding this comment.
This class should probably get moved out of the REST namespace
jblz
force-pushed
the
add/dynamic-block-registration
branch
from
8769930 to
b06aba5
Compare
…use instead of extending HttpDatasource themselves, support endpoint variations for tables in the former
jblz
force-pushed
the
add/dynamic-block-registration
branch
from
735af4e to
3206064
Compare
| public function set_slug( string $slug ): void { | ||
| $this->slug = $slug; | ||
| } | ||
|
|
||
| public function get_slug(): string { | ||
| return $this->slug; | ||
| } |
There was a problem hiding this comment.
What is the purpose of the slug?
There was a problem hiding this comment.
This was meant to be the predictable unique identifier, so that we can reference the credentials in example code using this, and then users could tag the data source in the Settings Page with this slug. So the slug would act as a link between those 2 systems. Earlier we had uuid as unique identifier, but that is not predictable until user adds the data source from Setting Page. Open to other ideas if they seem easier, this was just the first thought that popped into my mind.
… add/dynamic-block-registration
jblz
changed the title
| // Transform data to our experimental format, which is all array based | ||
| $config = array_map( | ||
| function ( $value ) { | ||
| return is_object( $value ) ? (array) $value : $value; | ||
| }, | ||
| (array) $config | ||
| ); |
There was a problem hiding this comment.
this was a hack when i was bumbling about in that unmerged try, but, at this point (hopefully) unnecessary.
(though I still think we should array everywhere personally!)
Much of this came in via #39, so I've limited it to abstracting the Airtable config.
The examples pull in a
AirtableDatasourceand provide a table "variation" (for lack of a better name -- any ideas to improve the API?) instead of hard-coding the endpoint.This lets us use a similar approach to dynamically register blocks for Airtable sources saved in the db, etc.