Add GitHub File as HTML block #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdef
changed the base branch from
trunk
to
hewsut/move-response-processing-to-query-context
mhsdef
changed the base branch from
hewsut/move-response-processing-to-query-context
to
trunk
chriszarate
reviewed
Sep 4, 2024
| public function get_endpoint( array $input_variables ): string { | ||
| return sprintf( | ||
| 'https://api.github.com/repos/%s/%s/contents/%s?ref=%s', | ||
| $this->get_datasource()->repo_owner, |
There was a problem hiding this comment.
Shouldn't this be an input variable?
There was a problem hiding this comment.
Sounds like yes.
I'll tweak. I need to get my head screwed on better in this part. The way inputs and outputs pipe between each other is still pretty magic to me.
…hewsut/add-github-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub File as HTML block. The main query, for now, requires a file extension hardcoded in registration to determine the types of files to list.
The file that is selected is fetched from GitHub as HTML and inserted into the current page via a pattern that binds the source to a paragraph block. Not ideal semantically, but, the best we have there in binding at the moment. The result renders nicely in spite of the
<p>wrapping.