-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add google sheets data source in settings page #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekharnwagh
force-pushed
the
add/google-oauth
branch
2 times, most recently
from
September 4, 2024 11:03
e8c9c37
to
49ee8e8
Compare
shekharnwagh
force-pushed
the
add/google-oauth
branch
from
September 4, 2024 11:06
49ee8e8
to
4cfb73e
Compare
shekharnwagh
changed the title
[WIP] add google sheets integration
add google sheets data source in settings page
Sep 6, 2024
shekharnwagh
requested review from
chriszarate,
mhsdef,
jblz,
maxschmeling and
mehmoodak
September 6, 2024 16:51
maxschmeling
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Maybe a few additional code comments that could be useful, but we can improve on that as we continue working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new type of data source in Settings Page - Google Sheets. It uses service accounts to authenticate and fetch data from Google Sheets. This is the first data source which uses OAuth2.0 to authenticate.
The flow for adding a Google Sheet data source is as follows:
Currently the saved data sources configured in the Settings Page are not hooked up with the registered blocks.
A separate PR will be made to add an example blocks for Google Sheets data source.