-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow association of patterns with remote data blocks #54
Conversation
I can get to the dialog and set a pattern association as shown. But, it's not showing when I go to select with the block. Any tips for testing? |
After making the association, it does require you to set a binding for at least one of the blocks in the pattern. This should be made clear somewhere, likely the pattern selection modal. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #54 +/- ##
============================================
+ Coverage 14.22% 14.28% +0.05%
Complexity 396 396
============================================
Files 122 126 +4
Lines 5019 5098 +79
Branches 146 150 +4
============================================
+ Hits 714 728 +14
- Misses 4161 4222 +61
- Partials 144 148 +4 ☔ View full report in Codecov by Sentry. |
woof, sorry for the noise, first time using codecov and this is what it's doing out of the box. I'll try the pattern association some more. And see if I can dial down this bot. |
I'll dial or rip that thing out tomorrow. https://docs.codecov.com/docs/common-recipe-list It's def not meant to be blocking. Or quite so noisy. Just looking for holistic picture. |
Nice. Got it wired together. Pain in a lot of places, but, mostly that's on core for how half baked these pieces we need are right now. Good step. 👍 |
Render a select box in pattern editor to associate patterns with remote data blocks. This allows patterns (synced and unsynced) to be included in the pattern chooser and for the block binding controls to be rendered in the pattern editor.