First commit: just trying out an email server. #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
force-pushed
the
try/email-service
branch
from
8ff4e7f to
21fe069
Compare
ramonjd
commented
Apr 26, 2025
vendor/wp-now/src/wp-now.ts
Outdated
| path.posix.join( PLAYGROUND_INTERNAL_MU_PLUGINS_FOLDER, '0-wp-mail.php' ), | ||
| `<?php | ||
| add_filter( 'wp_mail', function( $args ) { | ||
| $response = wp_remote_post( 'http://localhost:7777/email', array( |
There was a problem hiding this comment.
TODO: the port number should be dynamic.
It's set in the app.
- PHP const?
- WP option?
- ...
There was a problem hiding this comment.
I'm thinking this should be copied to /mu-plugins/ for each separate site.
This would simplify setting internal constants for the port number.
Also, users might want use a customized or other local email server.
…d readability. Enhance ContentTabSettings with email configuration details and a user-friendly message about the email service. Remove unused mu-plugin related to email functionality.
ramonjd
force-pushed
the
try/email-service
branch
from
21fe069 to
7104c3c
Compare
ramonjd
commented
Apr 26, 2025
src/lib/email-server.ts
Outdated
| const app = express(); | ||
| app.use( express.json() ); | ||
|
|
||
| // @TODO: service should be configurable via Studio settings. |
There was a problem hiding this comment.
The default would be Ethereal catch all for all sites.
Should sites be able to use separate email services? For example, a user might want site x to use gmail and not care about other sites?
Or should settings affect all sites?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Just testing forwarding WordPress emails to nodemailer.
The first iteration created a dedicated express server.
The second sets up a route on each site's express app. Each site has dedicated email host settings. This is more flexible as it allows users to set up different accounts for each site.
Questions/TODOs:
Should the port be dynamic? What would this look like?we can set up a route on each site's express serverTesting Instructions
Add an email and app password (use Gmail for testing, it's easier)
Click on WP Admin link on a site.
Then add a user, making sure to send them an email.
See if it works.
Pre-merge Checklist