Skip to content

add studio cli to whats new modal #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Apr 15, 2025

Related issues

  • Fixes STU-261

Proposed Changes

  • Updates the What's New modal to include information about the new Studio CLI tool
  • Adds a new card with Studio CLI illustration and description
  • Includes a link to the blog post for more information

Testing Instructions

  • Run npm start
  • Open Studio
  • Click on the "What's New" button in the top navigation
  • Verify that the new CLI card appears in the modal
  • Verify that the card shows the correct illustration, title, and description
  • Verify that the "Learn More" link points to the correct blog post URL

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@bcotrim bcotrim requested a review from a team April 15, 2025 16:29
@bcotrim bcotrim self-assigned this Apr 15, 2025
Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this, and it works as expected. The correct illustration is not showing right now, and the issue mentioned that it is not ready.

CleanShot 2025-04-16 at 10 28 14@2x

image: studioIllustration,
title: __( 'Introducing Studio by WordPress.com CLI' ),
description: __(
'Run commands and manage preview sites from your terminal! Use the `studio` command and create, list, update, and delete preview sites with our new CLI tool.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this copy slightly shorter so that it fully fits on the modal without being cut off? Something like Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool. perhaps? or something similar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katinthehatsite @ivan-ottinger, I'm a little concerned about forcefully limiting the line count. From a design perspective, it makes sense as a rule of thumb, but translations can change the length of the string, and it looks odd when the text gets cut off. How difficult would it be to adapt the height dynamically?

@@ -58,6 +58,14 @@ export default function WhatsNewModal( { showModal, onClose }: WhatsNewModalProp
'Discover the latest updates in Studio! Explore exciting new features designed to enhance your experience.'
),
},
{
image: studioIllustration,
title: __( 'Introducing Studio by WordPress.com CLI' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we flip the wording a bit? Or maybe we could skip WordPress.com here?

Suggested change
title: __( 'Introducing Studio by WordPress.com CLI' ),
title: __( 'Introducing Studio CLI by WordPress.com' ),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be consistent with the CLI.
Should we adjust the wording in both places?

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, I agree with Wojtek that we can skip "by WordPress.com"

description: __(
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.'
),
learnMoreUrl: 'https://wordpress.com/blog/2025/04/01/studio-cli/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There won't be a blog post for this release (see Marketing in pesfPa-1pM-p2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a Learn more link, though, so let's target a support doc instead.

@@ -58,6 +58,14 @@ export default function WhatsNewModal( { showModal, onClose }: WhatsNewModalProp
'Discover the latest updates in Studio! Explore exciting new features designed to enhance your experience.'
),
},
{
image: studioIllustration,
title: __( 'Introducing Studio by WordPress.com CLI' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, I agree with Wojtek that we can skip "by WordPress.com"

Comment on lines 64 to 66
description: __(
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.'
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: __(
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.'
),
description: sprintf(
/* translators: %s is the name of the Studio CLI command ("studio") */
__(
'Run the %s command in your terminal to create, list, update, and delete preview sites with our new CLI tool.'
),
'<code>studio</code>'
),

Adding a <code> wrapper around "studio" is just a suggestion, but regarding the phrasing, I would definitely add a "the" before "studio command".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also go back to your original approach of using backticks around the studio command name, @bcotrim. It looks better with a <code> wrapper, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants