-
Notifications
You must be signed in to change notification settings - Fork 29
add studio cli to whats new modal #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
add studio cli to whats new modal #1213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: studioIllustration, | ||
title: __( 'Introducing Studio by WordPress.com CLI' ), | ||
description: __( | ||
'Run commands and manage preview sites from your terminal! Use the `studio` command and create, list, update, and delete preview sites with our new CLI tool.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about making this copy slightly shorter so that it fully fits on the modal without being cut off? Something like Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.
perhaps? or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katinthehatsite @ivan-ottinger, I'm a little concerned about forcefully limiting the line count. From a design perspective, it makes sense as a rule of thumb, but translations can change the length of the string, and it looks odd when the text gets cut off. How difficult would it be to adapt the height dynamically?
@@ -58,6 +58,14 @@ export default function WhatsNewModal( { showModal, onClose }: WhatsNewModalProp | |||
'Discover the latest updates in Studio! Explore exciting new features designed to enhance your experience.' | |||
), | |||
}, | |||
{ | |||
image: studioIllustration, | |||
title: __( 'Introducing Studio by WordPress.com CLI' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we flip the wording a bit? Or maybe we could skip WordPress.com here?
title: __( 'Introducing Studio by WordPress.com CLI' ), | |
title: __( 'Introducing Studio CLI by WordPress.com' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context, I agree with Wojtek that we can skip "by WordPress.com"
description: __( | ||
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.' | ||
), | ||
learnMoreUrl: 'https://wordpress.com/blog/2025/04/01/studio-cli/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There won't be a blog post for this release (see Marketing in pesfPa-1pM-p2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a Learn more
link, though, so let's target a support doc instead.
@@ -58,6 +58,14 @@ export default function WhatsNewModal( { showModal, onClose }: WhatsNewModalProp | |||
'Discover the latest updates in Studio! Explore exciting new features designed to enhance your experience.' | |||
), | |||
}, | |||
{ | |||
image: studioIllustration, | |||
title: __( 'Introducing Studio by WordPress.com CLI' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context, I agree with Wojtek that we can skip "by WordPress.com"
description: __( | ||
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.' | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: __( | |
'Run studio command in your terminal to create, list, update, and delete preview sites with our new CLI tool.' | |
), | |
description: sprintf( | |
/* translators: %s is the name of the Studio CLI command ("studio") */ | |
__( | |
'Run the %s command in your terminal to create, list, update, and delete preview sites with our new CLI tool.' | |
), | |
'<code>studio</code>' | |
), |
Adding a <code>
wrapper around "studio" is just a suggestion, but regarding the phrasing, I would definitely add a "the" before "studio command".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also go back to your original approach of using backticks around the studio command name, @bcotrim. It looks better with a <code>
wrapper, though.
Related issues
Proposed Changes
Testing Instructions
npm start
Pre-merge Checklist