Export: Exclude node_modules and .git paths from site export
#1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-ottinger
commented
Apr 25, 2025
Comment on lines
+233
to
+234
| const isNodeModulesDirectory = relativePath.includes( 'node_modules' ); | ||
| const isGitDirectory = relativePath.includes( '.git' ); |
There was a problem hiding this comment.
I think it should be safe to exclude all those paths that include node_modules or .git in them, but happy to make it more strict if you think it's necessary. 🙂
There was a problem hiding this comment.
I agree IMO this should be strict enough! 👌
epeicher
approved these changes
Apr 25, 2025
gcsecsey
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Thanks @ivan-ottinger for working on this and for adding such detailed testing steps! 🙌
The changes LGTM and it's working great for me too! Thanks @epeicher for the handy tree listing command, it made screenshotting much easier! 😄
| My site files | exported files |
|---|---|
 |
 |
Comment on lines
+233
to
+234
| const isNodeModulesDirectory = relativePath.includes( 'node_modules' ); | ||
| const isGitDirectory = relativePath.includes( '.git' ); |
There was a problem hiding this comment.
I agree IMO this should be strict enough! 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
node_modulesand.gitpaths from site exportTesting Instructions
npm start..gitandnode_moduleswith some random files in them./wp-content/plugins,/wp-content/themes, etc. ....gitornode_modulesdirectories present.Pre-merge Checklist