-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembler: Use variation partials and move styles.blocks.variations to styles.variations #7891
Conversation
Relies on WordPress/gutenberg#62712 merged, into Gutenberg and perhaps for WordPress 6.6. |
Preview changesI've detected changes to the following themes in this PR: Assembler. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
Tested well for me on Gutenberg trunk (18.7RC) and WP 6.5.5 |
Went ahead and tweaked the form input styles to work better across all block style variations as well. |
ba7ac8c
to
8656466
Compare
@alaczek @miksansegundo Do you mind giving this another good look over? Much appreciated! 🙇 |
I'm still reviewing this. So far, I have found some issues with some variations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It's working fine in the editor.
My confusion was that some of their colors, which look to me as the most representative, are used in the section style variations 1 to 3
, not necessarily on the default variation. Therefore, those colors won't appear on the previews until we add their corresponding CSS classes to some patterns.
Let's follow up with any adjustments to make the dotCom previews look better in:
- Theme showcase previews show the wrong color on the footer
- Assembler highlights the default colors on the variation miniatures, and many of them look black and white
Follow up to WordPress/gutenberg#62712, which adjusts where block style variations are defined with in theme style variations, as well as better leveraging style variation partials.
To test, load up WordPress/gutenberg#62712, then change to alternate color palettes. It should work exactly as previously.