Add ECE support to shipping subscriptions with free trial and sign up fee #10099
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
6 tasks
|
Size Change: +127 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
asumaran
requested review from
a team and
cesarcosta99
and removed request for
a team
asumaran
changed the title
asumaran
force-pushed
the
as-fix-ece-shipping-subs-with-free-trial-and-sign-up-fee-tokenized-carts
branch
from
40c0e5e to
fd72201
Compare
|
We’ll wait for the Tokenized Carts feature to be merged before marking this PR as ready for review. |
|
I found a bug in Case 12: opening, closing, and then reopening the payment sheet causes it to fail. This might be because the initial amount is higher than the updated amount after click. I need to investigate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9771
Changes proposed in this Pull Request
Enables ECE for subscriptions that require shipping with a free trial and sign-up fee.
Testing instructions
Verify ECE is enabled for case 4
Verify ECE is enabled for case 12
Verify ECE is not enabled for Case 3
Verify ECE is not enabled for Case 11
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge