Add support to offline payment methods in checkout #10219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
gpressutto5
requested review from
a team and
danielmx-dev
and removed request for
a team
danielmx-dev
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Works well!
I tested the following scenarios:
- Regular credit card purchase
- 3D Secure CC purchase
- Redirect payment method purchase (Bancontact)
Additionally I marked Bancontact as an offline payment method and verified that the order received page was loaded immediately after checkout and that the order was put on hold.
|
Great idea to test with a redirect payment method! |
gpressutto5
deleted the
feat/add-support-to-offline-payment-methods-to-develop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10124
Changes proposed in this Pull Request
This PR sets up the foundation for adding offline payment methods, such as Multibanco. By itself, it doesn’t alter any existing functionality or introduce new features, but it enables us to proceed with implementing offline methods. That’s why it should be merged into a release branch instead of develop.
It was created based on the POC in #10191 and adapted so it can be merged without depending on the POC.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge