Cache get WC orders for incentives #10231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
vladolaru
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Thank you for handling this enhancement, @elazzabi! The code changes LGTM!
There is one thing we can do better: extend the caching period to almost 90 days. See how it is implemented in the WC core. Oh, and also include refunded orders (also see the WC core implementation).
dpaun1985
approved these changes
Jan 27, 2025
| $has_orders = ! empty( | ||
| wc_get_orders( | ||
| [ | ||
| 'status' => [ 'wc-completed', 'wc-processing' ], |
There was a problem hiding this comment.
I think we could use the constants from OrderInternalStatus
There was a problem hiding this comment.
Hey 👋 I see that the class is in Core, so I think that's why we opted for hard coding the values 🤔
There was a problem hiding this comment.
Yeah. The OrderInternalStatus class was introduced in Nov 2024. I don't think we can reliably jump on relying on it. This would make WooPayments incompatible with WC versions older than that.
@elazzabi, I don't have a strong opinion on matching the core implementation. Considering the "closer to core" goal, it wouldn't hurt to be as close as possible. But our Database Cache can handle it, no problems. I will leave it up to you to decide. |
|
@vladolaru Thanks! I would love to reduce the gap with Core, but I'm short on time at the moment. I will revisit it again if it's still open once I'm back 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10046
Changes proposed in this Pull Request
This fix adds a caching layer when checking for orders as part of the incentives class. If orders are present, we cache for a longer period (1 week), if not, we cache for a shorter one (1 hour).
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge