-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Shopper Blocks Checkout Failures spec to Playwright #10232
Convert Shopper Blocks Checkout Failures spec to Playwright #10232
Conversation
…eckout-purchase-with-upe-methods
…right
…-blocks-saved-card-checkout-and-usage
…-blocks-saved-card-checkout-and-usage
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
…-blocks-saved-card-checkout-and-usage
…-blocks-saved-card-checkout-and-usage
…-blocks-saved-card-checkout-and-usage
…card-checkout-and-usage' into dev/10073-convert-shopper-wc-blocks-checkout-failures-spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn’t get the tests to pass locally because they always fail at this line. However, if I comment it out, the tests pass successfully on my end.
@tpaksu do you know if we need that line? It feels that the Stripe element is already loaded, so it hangs forever.
@eduardoumpierre, I guess not. As I said before, |
@eduardoumpierre I've pushed the base branch to the merge queue, so we can fix the flakiness on this PR directly. |
…out-failures-spec
@eduardoumpierre and @tpaksu I didn't run into this. I started a fresh e2e env and all tests passed on the first pass. That said, the Playwright docs discourage the use of https://playwright.dev/docs/api/class-page#page-wait-for-load-state-option-state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this one, Ismael. The code looks great. I set up a fresh e2e env and the tests all passed on the first attempt. I've run them a couple of more times and they all pass each time.
Co-authored-by: Taha Paksu <[email protected]> Co-authored-by: Jesse Pearson <[email protected]> Co-authored-by: Eduardo Umpierre <[email protected]> Co-authored-by: Allie Mims <[email protected]>
Fixes #10073
Depends on #10223, which implements the base WEB methods.
Changes proposed in this Pull Request
Convert shopper-wc-blocks-checkout-failures spec from Puppeteer to Playwright.
Testing instructions
dev/10073-convert-shopper-wc-blocks-checkout-failures-spec
npm run test:e2e-pw shopper-wc-blocks-checkout-failures
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge