Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Shopper Blocks Checkout Failures spec to Playwright #10232

Merged

Conversation

ismaeldcom
Copy link
Contributor

@ismaeldcom ismaeldcom commented Jan 24, 2025

Fixes #10073

Depends on #10223, which implements the base WEB methods.

Changes proposed in this Pull Request

Convert shopper-wc-blocks-checkout-failures spec from Puppeteer to Playwright.

Testing instructions

  • Checkout dev/10073-convert-shopper-wc-blocks-checkout-failures-spec
  • Run npm run test:e2e-pw shopper-wc-blocks-checkout-failures
  • Test should pass locally.
  • Test should pass in GH actions.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

Sorry, something went wrong.

tpaksu and others added 21 commits January 21, 2025 10:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…eckout-purchase-with-upe-methods
…-blocks-saved-card-checkout-and-usage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-blocks-saved-card-checkout-and-usage
@ismaeldcom ismaeldcom self-assigned this Jan 24, 2025
@botwoo

This comment was marked as off-topic.

This comment was marked as off-topic.

@ismaeldcom ismaeldcom requested a review from a team January 24, 2025 12:34
tpaksu and others added 4 commits January 24, 2025 14:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-blocks-saved-card-checkout-and-usage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-blocks-saved-card-checkout-and-usage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-blocks-saved-card-checkout-and-usage
tpaksu and others added 2 commits January 28, 2025 20:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…card-checkout-and-usage' into dev/10073-convert-shopper-wc-blocks-checkout-failures-spec
Copy link
Contributor

@eduardoumpierre eduardoumpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn’t get the tests to pass locally because they always fail at this line. However, if I comment it out, the tests pass successfully on my end.

@tpaksu do you know if we need that line? It feels that the Stripe element is already loaded, so it hangs forever.

@tpaksu
Copy link
Contributor

tpaksu commented Jan 28, 2025

@eduardoumpierre, I guess not. As I said before, wait* is evil. Do you want me to remove it and have the base branch start the tests again? 😭

@tpaksu
Copy link
Contributor

tpaksu commented Jan 28, 2025

@eduardoumpierre I've pushed the base branch to the merge queue, so we can fix the flakiness on this PR directly.

Base automatically changed from dev/10075-playwright-migration-shopper-wc-blocks-saved-card-checkout-and-usage to develop January 28, 2025 18:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…out-failures-spec
@allie500
Copy link
Contributor

I couldn’t get the tests to pass locally because they always fail at this line. However, if I comment it out, the tests pass successfully on my end.

@tpaksu do you know if we need that line? It feels that the Stripe element is already loaded, so it hangs forever.

@eduardoumpierre and @tpaksu I didn't run into this. I started a fresh e2e env and all tests passed on the first pass. That said, the Playwright docs discourage the use of waitForLoadState( 'networkidle' ).

https://playwright.dev/docs/api/class-page#page-wait-for-load-state-option-state

Copy link
Contributor

@allie500 allie500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this one, Ismael. The code looks great. I set up a fresh e2e env and the tests all passed on the first attempt. I've run them a couple of more times and they all pass each time.

:shipit:

@ismaeldcom ismaeldcom added this pull request to the merge queue Jan 29, 2025
Merged via the queue into develop with commit ecf757a Jan 29, 2025
24 of 25 checks passed
@ismaeldcom ismaeldcom deleted the dev/10073-convert-shopper-wc-blocks-checkout-failures-spec branch January 29, 2025 07:47
dmvrtx pushed a commit that referenced this pull request Jan 31, 2025

Verified

This commit was signed with the committer’s verified signature.
dmvrtx Valery Sukhomlinov
Co-authored-by: Taha Paksu <[email protected]>
Co-authored-by: Jesse Pearson <[email protected]>
Co-authored-by: Eduardo Umpierre <[email protected]>
Co-authored-by: Allie Mims <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Playwright Migration: convert shopper-wc-blocks-checkout-failures spec
6 participants