Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrabPay: Add settings page. #10235
GrabPay: Add settings page. #10235
Changes from 11 commits
1322335
66bda70
f49e7c8
3e58e5c
e60e65c
8640e0c
2ff7521
fd3af9f
024594d
dc6eee9
6273972
4c46d56
0cff770
01277ad
f175834
ab3b6ed
a96d991
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the note about Malaysia support, but I also see that Malaysia was added to the countries list. Should Malaysia be listed here yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The countries listed here are the countries where the payment method is available for shoppers. The payment method eligibility for merchants (based on the Stripe account's country) is determined by the server, and that is what I meant in the comment. I'll edit the comment to provide more clarity.