Convert the Merchant Order Status Change E2E spec to Playwright #10243
+204
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Comment on lines
60
to
62
| await merchantPage.waitForSelector( cancelModalSelector, { | ||
| state: 'visible', | ||
| } ); |
There was a problem hiding this comment.
In the doc for waitForSelector it says:
Use web assertions that assert visibility or a locator-based locator.waitFor() instead.
Would we want to swap these out? The code would be a little more complex from what I see, but it may be a little more future proof, unless I am missing something.
There was a problem hiding this comment.
Great call! I've updated the code to use locator.waitFor() instead on 70add24. Thanks for raising that!
jessepearson
approved these changes
Jan 28, 2025
…g order" This reverts commit 073e8f0.
dmvrtx
pushed a commit
that referenced
this pull request
Jan 31, 2025
Co-authored-by: Taha Paksu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9965
Changes proposed in this Pull Request
This PR aims to migrate the "Merchant > Order Status Change" spec to Playwright, removing the corresponding test from the Puppeteer test suite.
Testing instructions
npm run test:e2e-resetnpm run test:e2e-setupnpm run test:e2e-pw merchant-orders-status-change.specnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge