Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbum Block Editor: Remove comment area scroll #92238

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jul 1, 2024

Fixes p4vt7e-io-p2

Proposed Changes

  • Updates styling for Verbum Block Editor to remove the scrolling inside the comment text area.

Why are these changes being made?

  • Currently, the Verbum Block Editor comment text has an unnecessary scrollbar, leading to an odd user experience and affecting accessibility. The comment text area automatically expands/shrinks as content is added or removed, so the scrollbar is unnecessary.

Testing Instructions

  • Checkout branch
  • Navigate to /packages/verbum-block-editor and run yarn dev --sync to sync to your sandbox
  • Sandbox Widgets API
  • Verify the comment text area does not have a scrollbar and test for regressions ( Add and remove text/blocks ).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95 agrullon95 changed the title Remove comment area scroll Verbum Block Editor: Remove comment area scroll Jul 1, 2024
@agrullon95 agrullon95 marked this pull request as ready for review July 1, 2024 15:39
@agrullon95 agrullon95 self-assigned this Jul 1, 2024
@agrullon95 agrullon95 requested a review from a team July 1, 2024 15:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 1, 2024
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@agrullon95 agrullon95 merged commit 223c8b6 into trunk Jul 2, 2024
16 checks passed
@agrullon95 agrullon95 deleted the fix/verbum-editor-comment-area-scroll branch July 2, 2024 21:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants