Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect skipped checkout in launchpad selected plan #92280

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Jul 2, 2024

Whenever a user skips purchasing the plan he selected we should customize the launchpad experience.

  1. The Choose a plan (plan_selected) task should be marked an uncompleted
  2. The header should change from "Let's get ready to launch" to "Get started with WordPress.com"

Fixes #92243

Proposed Changes

  • Redirect with param when closing checkout
  • Apply the launchpad customizations based on this

Testing Instructions

  • Follow the onboarding flow /start
  • Select a paid plan
  • Click the close checkout button
  • Ensure that skippedCheckout is added to the URL
  • Don't select goals so that we default with the build intent
  • Select a design
  • Ensure that the customizations for the title and selected plan are applied to the launchpad

Testing flows from stepper

  • Follow the /start/newsletter flow
  • Select a paid plan
  • Click the close checkout button
  • Ensure that skippedCheckout is added to the URL
  • Ensure that the selected plan task is marked as incomplete

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/skipped-checkout-selected-plan on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jul 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~158 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
link-in-bio-tld-flow       +300 B  (+0.0%)      +77 B  (+0.0%)
write-flow                 +271 B  (+0.0%)      +68 B  (+0.0%)
videopress-flow            +271 B  (+0.0%)      +68 B  (+0.0%)
build-flow                 +271 B  (+0.0%)      +68 B  (+0.0%)
checkout                   +127 B  (+0.0%)      +33 B  (+0.0%)
site-setup-wg               +74 B  (+0.1%)      +23 B  (+0.2%)
site-setup-flow             +74 B  (+0.1%)      +23 B  (+0.2%)
update-design-flow          +29 B  (+0.0%)       +9 B  (+0.0%)
signup                      +29 B  (+0.0%)       +9 B  (+0.0%)
newsletter-flow             +20 B  (+0.1%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~73 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +127 B  (+0.0%)      +33 B  (+0.0%)
async-load-calypso-layout-masterbar-checkout-tsx       +127 B  (+0.1%)      +40 B  (+0.1%)
async-load-calypso-layout-masterbar-checkout           +127 B  (+0.2%)      +40 B  (+0.2%)
async-load-calypso-blocks-editor-checkout-modal        +127 B  (+0.0%)      +33 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@heavyweight heavyweight force-pushed the fix/skipped-checkout-selected-plan branch from 1058337 to 5a81d2d Compare July 2, 2024 12:50
@heavyweight heavyweight requested a review from a team July 3, 2024 06:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 3, 2024
@heavyweight heavyweight linked an issue Jul 3, 2024 that may be closed by this pull request
@heavyweight heavyweight added Post Checkout [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Jul 3, 2024
@heavyweight heavyweight changed the base branch from trunk to fix/consistent-destination-after-checkout July 3, 2024 07:25
Base automatically changed from fix/consistent-destination-after-checkout to trunk July 4, 2024 02:32
@escapemanuele escapemanuele added this to To do in Signup and Login Improvements via automation Jul 4, 2024
@heavyweight heavyweight marked this pull request as ready for review July 4, 2024 10:22
@heavyweight heavyweight requested a review from a team as a code owner July 4, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. Post Checkout [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Development

Successfully merging this pull request may close these issues.

Back from Checkout: Tailor the Launchpad experience
3 participants