Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Add the possibility of exiting the Instructions step in the Assisted Migration flow #92289

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

valterlorran
Copy link
Contributor

@valterlorran valterlorran commented Jul 2, 2024

Related to #92260

Proposed Changes

Before

Captura de Tela 2024-07-02 às 12 09 18

After

Captura de Tela 2024-07-02 às 12 07 47

Why are these changes being made?

  • We noticed that the instruction step after the Assisted Migration flow would leave the user on a Dead-end step without the possibility of redirecting them to further exploration of our platform.

Testing Instructions

  • Apply this PR to your local environment or use the Calypso Live link below
  • Navigate to /start and go through the migration flow until you reach the "What do you want to do?" step.
  • Select "Migrate site"
  • On the "How to migrate" step, select the "Do it for me" option
  • Go through the checkout in case you are testing on a free site
  • You should land on the assisted migration instruction step
  • You should now see two cards on the bottom. Click on both of them and check that you are being redirected to the Customer Home page and the Support page.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jul 2, 2024
@valterlorran valterlorran requested a review from a team July 2, 2024 15:12
@valterlorran valterlorran self-assigned this Jul 2, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 2, 2024
@matticbot
Copy link
Contributor

matticbot commented Jul 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +210 B  (+0.0%)       +2 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~716 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
import-hosted-site-flow        +11441 B  (+1.4%)    +3961 B  (+1.6%)
with-theme-assembler-flow        +360 B  (+0.6%)      +22 B  (+0.2%)
update-options-flow              +360 B  (+0.8%)      +21 B  (+0.4%)
update-design-flow               +360 B  (+0.0%)      +26 B  (+0.0%)
trial-wooexpress-flow            +360 B  (+0.8%)      +23 B  (+0.3%)
tailored-ecommerce-flow          +360 B  (+0.8%)      +20 B  (+0.3%)
site-setup-wg                    +360 B  (+0.5%)      +23 B  (+0.2%)
site-setup-flow                  +360 B  (+0.5%)      +23 B  (+0.2%)
site-migration-flow              +360 B  (+0.7%)      +21 B  (+0.2%)
readymade-template-flow          +360 B  (+0.2%)      +22 B  (+0.1%)
migration-signup                 +360 B  (+0.7%)      +18 B  (+0.2%)
import-flow                      +360 B  (+0.7%)      +21 B  (+0.2%)
hosted-site-migration-flow       +360 B  (+0.7%)      +22 B  (+0.2%)
free-post-setup-flow             +360 B  (+0.8%)      +20 B  (+0.4%)
free-flow                        +360 B  (+0.7%)      +21 B  (+0.2%)
entrepreneur-flow                +360 B  (+0.3%)      +21 B  (+0.1%)
assembler-first-flow             +360 B  (+0.5%)      +19 B  (+0.1%)
ai-assembler-flow                +360 B  (+0.5%)      +21 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@valterlorran valterlorran force-pushed the add/exit-to-do-it-for-me-dead-end branch from d49822d to 7411dd1 Compare July 2, 2024 15:17
@matticbot
Copy link
Contributor

matticbot commented Jul 2, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/exit-to-do-it-for-me-dead-end on your sandbox.

@valterlorran valterlorran added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jul 2, 2024
@valterlorran valterlorran added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jul 2, 2024
@a8ci18n
Copy link

a8ci18n commented Jul 2, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15937585

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @valterlorran for including a screenshot in the description! This is really helpful for our translators.

@valterlorran valterlorran force-pushed the add/exit-to-do-it-for-me-dead-end branch from 92072da to 3657359 Compare July 3, 2024 17:43
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valterlorran valterlorran merged commit c4bc335 into trunk Jul 3, 2024
11 checks passed
@valterlorran valterlorran deleted the add/exit-to-do-it-for-me-dead-end branch July 3, 2024 21:15
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jul 3, 2024
yashwin pushed a commit that referenced this pull request Jul 4, 2024
…in the Assisted Migration flow (#92289)

* Add an exit to the Do-it-for-me dead-end page

* remove extra space

* Remove unused Button import

---------

Co-authored-by: Mark Biek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants