Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Color Scheme: Update to match wp-admin #92398

Closed
wants to merge 8 commits into from

Conversation

chad1008
Copy link
Contributor

@chad1008 chad1008 commented Jul 4, 2024

Part of 7884-gh-Automattic/dotcom-forge

Proposed Changes

Updates the Light color scheme to address discrepancies from wp-admin, for a more consistent user experience.

Why are these changes being made?

An issue recently highlighted some disconnects that have developed between our unified/redesigned sidebars and the wp-admin styles for various color schemes. This PR is addresses those for the Light color scheme.

Note

Because the schemes depend on the variables provided by client/my-sites/sidebar/style.scss, this PR is branched off of #92397.

If any changes are recommended for client/my-sites/sidebar/style.scss, please leave a note on that PR instead of this one, so I can make changes there, and then rebase the individual scheme PRs.

Testing Instructions

There are three views we care about:

  • Calypso sidebar
  • My Home/Hosting sidebar
  • wp-admin (the control that we're updating schemes to match again)
  1. Select a simple site and make sure you have the "default" view (i.e. Calypso) selected
  2. In a separate tab, select an Atomic site. Under Settings > General, choose the wp-admin/classic interaface. Open any wp-admin page.
  3. In a third tab, select Tools > Hosting for your Atomic site. This should open /home/[site-url], where you'll find a Calypso interface with the Hosting section open to the My Home submenu item
  4. Activate the Light color scheme for your site
  5. In both of your Calypso-based tabs, confirm that the following match wp-admin(hopefully exactly, but at least visually close enough to provide a good UX):
    5.1. Unfocused text and background colors for menu items and submenu items
    5.2. Unfocused text and background colors in the flyout when hovering over an expandable item like "Posts"
    5.3. Unfocused text and background colors in the in-sidebar submenu when an expandable item is selected
    5.4. Unfocused text and background colors for the currently selected items (e.g. Posts) and submenu items (e.g. All Posts)
    5.5. Hover text and background colors for menu items and submenu items
    5.6. Hover text and background colors in the flyout when hovering over an expandable item like "Posts"
    5.7. Hover text and background colors in the in-sidebar submenu when an expandable item is selected
    5.8. Hover text and background colors for the currently selected items (e.g. Posts) and submenu items (e.g. All Posts)
    5.9. The "Collapse Menu" link, both unfocused and hovered

The hover states of a currently selected submenu item like "All Posts" and the "Collapse Menu" link were where I found the most nuance/variation from one scheme to the next.

@chad1008 chad1008 requested a review from a team July 4, 2024 17:18
@chad1008 chad1008 self-assigned this Jul 4, 2024
@chad1008 chad1008 requested review from fredrikekelund and removed request for a team July 4, 2024 17:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@chad1008 chad1008 requested a review from nightnei July 6, 2024 01:10
Copy link
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected 👍
Screenshot 2024-07-08 at 11 22 16
Screenshot 2024-07-08 at 11 22 29

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • editing-toolkit
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug chad1008/fix-light-color-scheme on your sandbox.

@chad1008
Copy link
Contributor Author

Merged and deployed with #92397

@chad1008 chad1008 closed this Jul 12, 2024
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants