Domains: Prevent email from being purchased for Gravatar domains #96085
+96
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~805 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~75 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
rafaelgallani
approved these changes
Nov 7, 2024
…mains Add notice to the email service selection page explaining that Gravatar domains cannot have email purchased for them.
leonardost
force-pushed
the
update/prevent-email-from-being-attached-to-100-year-domains
branch
from
832fe04
to
cbf9610
Compare
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
leonardost
deleted the
update/prevent-email-from-being-attached-to-100-year-domains
branch
github-actions
bot
removed
the
[Status] Needs Review
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17002203 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @leonardost for including a screenshot in the description! This is really helpful for our translators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR:
Some Gravatar domains already had email purchased for them. In those cases, users will still be able to manage their email subscription (renew, cancel) but won't be able to buy new mailboxes.
Depends on D165417-code.
This is part of the Custom Domains on Gravatar i2 project (pcYYhz-2oZ-p2).
Screenshots
Why are these changes being made?
We don't want Gravatar domains to have any email services attached to them for now.
Testing Instructions
If D165417-code wasn't merged yet, apply it to your sandbox.
Pre-merge Checklist