Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: send missing url #96294

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Help Center: send missing url #96294

merged 1 commit into from
Nov 13, 2024

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Nov 12, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/9774

Proposed Changes

  • We weren't sending the customer site in the user fields before creating a conversation.

Why are these changes being made?

  • The site url should be passed when submitting the user fields

Testing Instructions

  • Build this PR
  • Use the help-center-experience feature flag
  • Create a new conversation
  • Ensure that the url is passed when submitting the user fields
Screenshot 2024-11-12 at 16 53 07

@heavyweight heavyweight self-assigned this Nov 12, 2024
@heavyweight heavyweight marked this pull request as ready for review November 12, 2024 15:53
@heavyweight heavyweight requested a review from a team as a code owner November 12, 2024 15:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 12, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~32 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center        +99 B  (+0.0%)      +32 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@arcangelini arcangelini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2024-11-12 at 10 03 21

@agrullon95 agrullon95 self-requested a review November 12, 2024 20:44
Copy link
Contributor

@agrullon95 agrullon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified my site url is sent in the messaging_url parameter.

@escapemanuele escapemanuele changed the title HelpCenter: send missing url Help Center: send missing url Nov 13, 2024
@escapemanuele escapemanuele merged commit f4afc50 into trunk Nov 13, 2024
16 of 17 checks passed
@escapemanuele escapemanuele deleted the fix/hc-site-url branch November 13, 2024 11:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants